[Block Library - Query Loop]: Fix variation with declaredicon object with src
#44270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
ntsekouras
requested review from
mcsf,
Mamaduka,
oandregal and
jorgefilipecosta
|
Size Change: +10 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Sep 20, 2022
There was a problem hiding this comment.
The fix works well. Thanks, Nik.
I see that on the trunk, the variation icon is correctly rendered in a few places, like slash inserter results and block toolbar. But then fails in the Placeholder component.
Do you think we should make the Placeholder component more resilient like others?
|
Thanks for reviewing @Mamaduka! I think we shouldn't tweak Placeholder component as is a more generic one, in contrary to some of the block editor ones that take into account that the icon can be from the block type, and therefore include the |
|
Hey folks, I found a similar issue on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Currently if we register a Query Loop variation with having an
iconobject withsrcproperty - which is not adashicon- it will crash the block during the insertion, due to the lack of handling this case. This PR just adds some adhoc handling for this, as this is related to some implementation details to QueryPlaceholder component..It would be good to consider a better handling of variations validation similar to block types, but that should be discussed and handled separately. By playing around a bit, it has nuances in general because handling
registerBlockVariationisn't enough, as we operate on variations in places directly from theblockTypeobject.Testing Instructions
iconwithsrc. Example: