Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Templates Names and Descriptions: Code parity with wp/6.1 #44646

Merged

Conversation

cbravobernal
Copy link
Contributor

What?

This PR adds the comments done by @dream-encode to have parity with WordPress Core and the wp/6.1 branch.

@cbravobernal cbravobernal added [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Code Quality Issues or PRs that relate to code quality labels Oct 3, 2022
@dream-encode
Copy link

@c4rl0sbr4v0 I reverted the revert of https://core.trac.wordpress.org/changeset/54333 in https://core.trac.wordpress.org/changeset/54370.

The JS side of this is in the GB packages, and will need another build sync for 6.1 Beta 3 tomorrow.

@ockham
Copy link
Contributor

ockham commented Oct 5, 2022

@c4rl0sbr4v0 I reverted the revert of https://core.trac.wordpress.org/changeset/54333 in https://core.trac.wordpress.org/changeset/54370.

The JS side of this is in the GB packages, and will need another build sync for 6.1 Beta 3 tomorrow.

This has been addressed via #44645.

Copy link
Contributor

@ockham ockham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This seems to reflect the changes from this Core commit well (except for one minor discrepancy).

We might have to file another PR to apply changes suggested by @spacedmonkey (1, 2, 3); I think @dream-encode has filed a PR against wordpress-develop: WordPress/wordpress-develop#3404. So we can wait for that PR to land and then file a PR to carry those changes back over here.

@ockham ockham merged commit ca045f1 into trunk Oct 5, 2022
@ockham ockham deleted the revert/code-parity-43862-dynamic-template-names-descriptions branch October 5, 2022 16:07
@github-actions github-actions bot added this to the Gutenberg 14.4 milestone Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Code Quality Issues or PRs that relate to code quality
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants