Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/stale from 3.0.17 to 6.0.0 #44745

Merged
merged 5 commits into from
Oct 7, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 6, 2022

Bumps actions/stale from 3.0.17 to 6.0.0.

Release notes

Sourced from actions/stale's releases.

v6.0.0

⚠️ Breaking change ⚠️

Issues/PRs default close-issue-reason is now not_planned(#789)

V5.2.0

Features: New option include-only-assigned enables users to process only issues/PRs that are already assigned. If there is no assignees and this option is set, issue will not be processed per: issue/596

Fixes: Fix date comparison edge case PR/816

Dependency Updates: PR/812

Fix issue when days-before-close is more than days-before-stale

fixes a bug introduced in #717

fixed in #775

v5.1.0

[5.1.0]

Don't process stale issues right after they're marked stale Add close-issue-reason option #764#772 Various dependabot/dependency updates

v5.0.0

Features

v4.1.0

Features

v4.0.0

⚠️ This version contains breaking changes ⚠️

Features

Bug Fixes

  • dry-run: forbid mutations in dry-run (#500) (f1017f3), closes #499
  • logs: coloured logs (#465) (5fbbfba)
  • operations: fail fast the current batch to respect the operations limit (#474) (5f6f311), closes #466

... (truncated)

Changelog

Sourced from actions/stale's changelog.

Changelog

[6.0.0]

⚠️ Breaking change ⚠️

Issues/PRs default close-issue-reason is now not_planned(#789)

[5.1.0]

Don't process stale issues right after they're marked stale [Add close-issue-reason option]#764#772 Various dependabot/dependency updates

4.1.0 (2021-07-14)

Features

4.0.0 (2021-07-14)

Features

Bug Fixes

  • dry-run: forbid mutations in dry-run (#500) (f1017f3), closes #499
  • logs: coloured logs (#465) (5fbbfba)
  • operations: fail fast the current batch to respect the operations limit (#474) (5f6f311), closes #466
  • label comparison: make label comparison case insensitive #517, closes #516
  • filtering comments by actor could have strange behavior: "stale" comments are now detected based on if the message is the stale message not who made the comment(#519), fixes #441, #509, #518

Breaking Changes

  • The options skip-stale-issue-message and skip-stale-pr-message were removed. Instead, setting the options stale-issue-message and stale-pr-message will be enough to let the stale workflow add a comment. If the options are unset, a comment will not be added which was the equivalent of setting skip-stale-issue-message to true.
  • The operations-per-run option will be more effective. After migrating, you could face a failed-fast process workflow if you let the default value (30) or set it to a small number. In that case, you will see a warning at the end of the logs (if enabled) indicating that the workflow was stopped sooner to avoid consuming too much API calls. In most cases, you can just increase this limit to make sure to process everything in a single run.
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [actions/stale](https://github.com/actions/stale) from 3.0.17 to 6.0.0.
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](actions/stale@996798e...3de2653)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the [Tool] Dependency Extraction Webpack Plugin /packages/dependency-extraction-webpack-plugin label Oct 6, 2022
This was removed in version 4.0.0 of the action, along with `skip-stale-pr-message`. A lack of setting this option is now the same as setting `skip-stale-issue-message` to `true`.

See https://github.com/actions/stale/releases/tag/v4.0.0.
@desrosj desrosj requested review from Mamaduka, ockham and talldan and removed request for Mamaduka October 6, 2022 15:44
@desrosj
Copy link
Contributor

desrosj commented Oct 6, 2022

The most notable change here is that "Issues/PRs default close-issue-reason is now not_planned".

However, I think that this is a good change. So far, stale issues have been getting closed as completed, which is disingenuous.

@desrosj
Copy link
Contributor

desrosj commented Oct 6, 2022

@dependabot rebase.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 6, 2022

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@desrosj desrosj removed the [Tool] Dependency Extraction Webpack Plugin /packages/dependency-extraction-webpack-plugin label Oct 6, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 7, 2022

A newer version of actions/stale exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@desrosj
Copy link
Contributor

desrosj commented Oct 7, 2022

I'm going to merge this in. The change to not_planned makes sense. And we can always change the resolution to completed (the only other one supported) later on in a follow up.

@desrosj desrosj merged commit ac1d129 into trunk Oct 7, 2022
@desrosj desrosj deleted the dependabot/github_actions/actions/stale-6.0.0 branch October 7, 2022 19:06
@github-actions github-actions bot added this to the Gutenberg 14.4 milestone Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant