Viewport: Refactor ifViewportMatches to use RTL #44766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
Mamaduka
requested review from
tyxla and
ntsekouras
and removed request for
ajitbohra
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
ntsekouras
approved these changes
Oct 7, 2022
tyxla
reviewed
Oct 7, 2022
|
|
||
| expect( useViewportMatch ).toHaveBeenCalledWith( 'wide', '>=' ); | ||
|
|
||
| expect( screen.queryByText( 'Hello' ) ).toBeInTheDocument(); |
There was a problem hiding this comment.
Just wanted to point out that query* queries are recommended only when we're querying for elements that don't exist. In case they are expected to exist, we use get* queries. See this post from the library creator as the rationale for that.
There was a problem hiding this comment.
Thanks, @tyxla.
I just realized that after reading https://testing-library.com/docs/react-testing-library/cheatsheet#queries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR refactors
ifViewportMatchesHOC tests to use@testing-library/reactinstead ofreact-test-renderer.Why?
It is a part of recent efforts to use
@testing-library/reactas the project's primary testing library.How?
We're just using the
rendermethod from RTL and improving how assertions are made.Testing Instructions