Viewport: Refactor withViewportMatch to use RTL #44769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
tyxla
approved these changes
Oct 7, 2022
|
|
||
| /** | ||
| * Internal dependencies | ||
| */ | ||
| import '../store'; | ||
| import withViewportMatch from '../with-viewport-match'; | ||
|
|
||
| jest.mock( '@wordpress/compose/src/hooks/use-viewport-match' ); |
There was a problem hiding this comment.
Alternatively, maybe we could be able to avoid mocking useViewportMatch and rather render a useViewportMatch.__experimentalWidthProvider provider in the tree.
There was a problem hiding this comment.
Considering that withViewportMatch depends on values returned by useViewportMatch, mocking the hook here makes sense to me.
There was a problem hiding this comment.
Yeah, I'm happy with the mock as one of the paths forward, just wanted to mention that there could be an alternative 👍 Feel free to ship as-is (I approved it already)
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR refactors
withViewportMatchHOC tests to use@testing-library/reactinstead ofreact-test-renderer.Why?
It is a part of recent efforts to use @testing-library/react as the project's primary testing library.
How?
We're just using the
rendermethod from RTL and improving how assertions are made.Testing Instructions