Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in block.json schema #44798

Closed
wants to merge 1 commit into from
Closed

Fix typo in block.json schema #44798

wants to merge 1 commit into from

Conversation

t-hamano
Copy link
Contributor

@t-hamano t-hamano commented Oct 9, 2022

What?

Fix typo in block.json schema. There is no impact on the code.

@t-hamano t-hamano requested a review from ajlende as a code owner October 9, 2022 07:36
@t-hamano t-hamano self-assigned this Oct 9, 2022
@t-hamano t-hamano added the Developer Experience Ideas about improving block and theme developer experience label Oct 9, 2022
Mamaduka
Mamaduka approved these changes Oct 9, 2022
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @t-hamano!

@t-hamano
Copy link
Contributor Author

t-hamano commented Oct 9, 2022

When I merged this PR, I got an error message (I think it was something like "merge failed").
Curiously, the PR has been merged into trunk and the changes are reflected, but the status remains unresolved. I would like to close this PR as merging again may cause problems.

pr

@t-hamano t-hamano closed this Oct 9, 2022
@t-hamano
Copy link
Contributor Author

t-hamano commented Oct 9, 2022

@Mamaduka
Have you ever encountered a case like this? As it is, it may not get on the Gutenberg milestone or changelog, but this PR is a very minor typo correction, so if there are no problems, I will leave it closed.

@Mamaduka
Copy link
Member

Mamaduka commented Oct 9, 2022

I've seen a similar error before, but it usually got resolved after I refreshed the page.

@Mamaduka Mamaduka added this to the Gutenberg 14.4 milestone Oct 9, 2022
@Mamaduka Mamaduka deleted the fix/block-json-schema-typo branch October 9, 2022 13:55
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Oct 10, 2022
@t-hamano
Fix typo in block.json schema (WordPress#44798)
401be48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@ajlende ajlende Awaiting requested review from ajlende

Assignees

@t-hamano t-hamano

Labels
Developer Experience Ideas about improving block and theme developer experience
Projects
None yet
Milestone
Gutenberg 14.4
Development

Successfully merging this pull request may close these issues.
2 participants
@t-hamano @Mamaduka