Interface: Refactor FullscreenMode component tests to use RTL #44803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
30 tasks
|
Size Change: +340 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
tyxla
approved these changes
Oct 10, 2022
packages/interface/src/components/fullscreen-mode/test/index.js
Outdated
Show resolved
Hide resolved
| expect( document.body.classList.contains( 'is-fullscreen-mode' ) ).toBe( | ||
| true | ||
| ); | ||
| const { baseElement } = render( <FullscreenMode isActive={ true } /> ); |
| ); | ||
|
|
||
| unmount(); |
There was a problem hiding this comment.
Instead of calling unmount, does it make sense to just rerender() some <div /> so the original component is no longer in the component tree, which will ultimately trigger an unmount?
Since this is part of the API it could be the most explicit way to express what we're aiming to test, though, so feel free to keep it as-is.
There was a problem hiding this comment.
The unmount makes sense to me when testing effect cleanup.
packages/interface/src/components/fullscreen-mode/test/index.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Marin Atanasov <[email protected]>
Co-authored-by: Marin Atanasov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR of #44780.
PR refactors
FullscreenModecomponent tests to use@testing-library/reactinstead ofreact-test-renderer.Why?
It is a part of recent efforts to use
@testing-library/reactas the project's primary testing library.How?
We're just using the render method from RTL, improving how assertions.
Testing Instructions