Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose: Refactor useViewportMatch tests to RTL #44819

Merged
merged 2 commits into from
Oct 10, 2022
Merged

Compose: Refactor useViewportMatch tests to RTL #44819

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36c3b8e
Compose: Refactor useViewportMatch tests to RTL
tyxla Oct 10, 2022
85a5d1d
Add a clarifying comment
tyxla Oct 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
155 changes: 77 additions & 78 deletions packages/compose/src/hooks/use-viewport-match/test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import { create, act } from 'react-test-renderer';
import { render } from '@testing-library/react';

/**
* Internal dependencies
Expand All @@ -25,105 +25,104 @@ describe( 'useViewportMatch', () => {
};

it( 'should return true when the viewport matches', async () => {
let root;
useMediaQueryMock.mockReturnValue( true );

await act( async () => {
root = create( <TestComponent breakpoint="wide" operator="<" /> );
} );
expect( root.toJSON() ).toBe( 'useViewportMatch: true' );
const { container, rerender } = render(
<TestComponent breakpoint="wide" operator="<" />
);

await act( async () => {
root.update( <TestComponent breakpoint="medium" operator=">=" /> );
} );
expect( root.toJSON() ).toBe( 'useViewportMatch: true' );
expect( container ).toHaveTextContent( 'useViewportMatch: true' );

await act( async () => {
root.update( <TestComponent breakpoint="small" operator=">=" /> );
} );
expect( root.toJSON() ).toBe( 'useViewportMatch: true' );
rerender( <TestComponent breakpoint="medium" operator=">=" /> );

expect( useMediaQueryMock.mock.calls ).toEqual( [
[ '(max-width: 1280px)' ],
[ '(min-width: 782px)' ],
[ '(min-width: 600px)' ],
] );
expect( container ).toHaveTextContent( 'useViewportMatch: true' );

root.unmount();
rerender( <TestComponent breakpoint="small" operator=">=" /> );

expect( container ).toHaveTextContent( 'useViewportMatch: true' );

expect( useMediaQueryMock ).toHaveBeenCalledTimes( 3 );
expect( useMediaQueryMock ).toHaveBeenNthCalledWith(
1,
'(max-width: 1280px)'
);
expect( useMediaQueryMock ).toHaveBeenNthCalledWith(
2,
'(min-width: 782px)'
);
expect( useMediaQueryMock ).toHaveBeenNthCalledWith(
3,
'(min-width: 600px)'
);
} );

it( 'should return false when the viewport matches', async () => {
let root;
useMediaQueryMock.mockReturnValue( false );

await act( async () => {
root = create( <TestComponent breakpoint="huge" operator=">=" /> );
} );
expect( root.toJSON() ).toBe( 'useViewportMatch: false' );
const { container, rerender } = render(
<TestComponent breakpoint="huge" operator=">=" />
);

expect( container ).toHaveTextContent( 'useViewportMatch: false' );

await act( async () => {
root.update( <TestComponent breakpoint="large" operator="<" /> );
} );
expect( root.toJSON() ).toBe( 'useViewportMatch: false' );
rerender( <TestComponent breakpoint="large" operator="<" /> );

await act( async () => {
root.update( <TestComponent breakpoint="mobile" operator="<" /> );
} );
expect( root.toJSON() ).toBe( 'useViewportMatch: false' );
expect( container ).toHaveTextContent( 'useViewportMatch: false' );

expect( useMediaQueryMock.mock.calls ).toEqual( [
[ '(min-width: 1440px)' ],
[ '(max-width: 960px)' ],
[ '(max-width: 480px)' ],
] );
rerender( <TestComponent breakpoint="mobile" operator="<" /> );

root.unmount();
expect( container ).toHaveTextContent( 'useViewportMatch: false' );

expect( useMediaQueryMock ).toHaveBeenCalledTimes( 3 );
expect( useMediaQueryMock ).toHaveBeenNthCalledWith(
1,
'(min-width: 1440px)'
);
expect( useMediaQueryMock ).toHaveBeenNthCalledWith(
2,
'(max-width: 960px)'
);
expect( useMediaQueryMock ).toHaveBeenNthCalledWith(
3,
'(max-width: 480px)'
);
} );

it( 'should correctly simulate a value', async () => {
let root;
useMediaQueryMock.mockReturnValue( true );

const innerElement = <TestComponent breakpoint="wide" operator=">=" />;
const WidthProvider = useViewportMatch.__experimentalWidthProvider;

await act( async () => {
root = create(
<WidthProvider value={ 300 }>{ innerElement }</WidthProvider>
);
} );
expect( root.toJSON() ).toBe( 'useViewportMatch: false' );

await act( async () => {
root.update(
<WidthProvider value={ 1200 }>{ innerElement }</WidthProvider>
);
} );
expect( root.toJSON() ).toBe( 'useViewportMatch: false' );

await act( async () => {
root.update(
<WidthProvider value={ 1300 }>{ innerElement }</WidthProvider>
);
} );
expect( root.toJSON() ).toBe( 'useViewportMatch: true' );

await act( async () => {
root.update(
<WidthProvider value={ 1300 }>
<TestComponent breakpoint="wide" operator="<" />
</WidthProvider>
);
} );
expect( root.toJSON() ).toBe( 'useViewportMatch: false' );

expect( useMediaQueryMock.mock.calls ).toEqual( [
[ undefined ],
[ undefined ],
[ undefined ],
[ undefined ],
] );

root.unmount();
const { container, rerender } = render(
<WidthProvider value={ 300 }>{ innerElement }</WidthProvider>
);
expect( container ).toHaveTextContent( 'useViewportMatch: false' );

rerender(
<WidthProvider value={ 1200 }>{ innerElement }</WidthProvider>
);

expect( container ).toHaveTextContent( 'useViewportMatch: false' );

rerender(
<WidthProvider value={ 1300 }>{ innerElement }</WidthProvider>
);

expect( container ).toHaveTextContent( 'useViewportMatch: true' );

rerender(
<WidthProvider value={ 1300 }>
<TestComponent breakpoint="wide" operator="<" />
</WidthProvider>
);

expect( container ).toHaveTextContent( 'useViewportMatch: false' );

expect( useMediaQueryMock ).toHaveBeenCalledTimes( 4 );
expect( useMediaQueryMock ).toHaveBeenNthCalledWith( 1, undefined );
expect( useMediaQueryMock ).toHaveBeenNthCalledWith( 2, undefined );
expect( useMediaQueryMock ).toHaveBeenNthCalledWith( 3, undefined );
expect( useMediaQueryMock ).toHaveBeenNthCalledWith( 4, undefined );
Mamaduka marked this conversation as resolved.
Show resolved Hide resolved
} );
} );