Lodash: Refactor away from _.words() - take 2
#45281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Feature] Inserter
tyxla
requested review from
Mamaduka,
sgomes,
aristath,
jsnajdr,
talldan,
swissspidy,
chad1008,
ntsekouras and
fabiankaegy
|
Size Change: +337 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes the
_.words()usage completely and deprecates the function again.This is the second attempt to remove
_.words(), after #42467 broke inserter searching for non-latin characters (see #44644) and it was reverted in #44652.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
Similar to #42427, we're suggesting to use the
change-caselibrary, which offers modular functions for all the casing functions we use from Lodash (likesnakeCase,capitalize,startCase,camelCase,kebabCase), at a small price (the methods are small themselves), and has TS support. The benefit of using that external library for all those case conversion functions is that we won't have to maintain our own versions of them, and those are already broadly used and tested.In particular, we replace the single instance of
words()with a custom implementation that usesnoCase()to generate a normalized string of words, then splits it into an array and filters out the empty values.We're altering the default regexes that
noCase()uses, in order to properly provide unicode support and therefore support proper splitting to words for all languages.We're also adding another 2 assertions to the non-latin tests - one in Chinese Simplified and one in Bulgarian, to better cover non-latin support.
Testing Instructions
npm run test-unit packages/block-editor/src/components/inserter/test/search-items.jsmédia