Block Editor: Improve MediaReplaceFlow tests
#45424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Code Quality
tyxla
requested review from
draganescu,
Mamaduka,
mirka,
jsnajdr,
ciampo,
chad1008 and
ntsekouras
|
|
|
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
Mamaduka
approved these changes
Oct 31, 2022
|
Thanks, @tyxla! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR improves the tests of
MediaReplaceFlowby adhering to the best practices followed by most of our tests.Why?
Having a coherent codebase and following the best practices for writing explicit, readable, and maintainable tests.
How?
We're doing a few improvements:
screenqueries instead ofcontainer.querySelector. That fixes a fewno-containerviolations. This is the primary motivation for this PR in the first place.no-render-in-setuprule.user-eventinstead offireEvent. See Expressing user actions at a higher level testing-library/dom-testing-library#107 for motivation.Testing Instructions
Verify tests still pass:
npm run test:unit packages/block-editor/src/components/media-replace-flow/test/index.jscc @brookewp as I know she's been tackling related work.