Button: Remove unnecessary 'useCallback' #45584
Merged
+2
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Mamaduka
added
[Type] Code Quality
Mamaduka
requested review from
youknowriad and
tyxla
and removed request for
ajitbohra
|
Size Change: -17 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
tyxla
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR inlines the
onSetLinkRelcallback and removes unnecessaryuseCallbackhook usage.Why?
The
TextControlisn't memoized component and will re-render whenever its parent re-renders. We don't need to pass a referentially stable callback to it.Testing Instructions
Confirm you can update Button's rel attribute as before.