Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summarize "Available commands" section and refer them it to scripts docs #45636

Merged

Conversation

juanmaguitar
Copy link
Contributor

What?

This PR moves to a subpage the content of the "Available Commands" as this info is not strictly about the create-block package (but about the resulting plugin folder created when executing it)_
This PR is part of the solutions required to solve #45519

Why?

Because this package is the main tool to create blocks and the learning experience of this package could be improved by separating concepts

How?

By moving this section to a subpage at the same level than External Project Templates

@codesandbox
Copy link

codesandbox bot commented Nov 9, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

Copy link
Member

@ramonjd ramonjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ramonjd
Copy link
Member

ramonjd commented Nov 9, 2022

We might need to run npm run docs:build on this branch, which I think will update docs/manifest.json

@vcanales
Copy link
Member

vcanales commented Nov 9, 2022

Could this be a link to https://github.com/WordPress/gutenberg/tree/HEAD/packages/scripts#available-scripts instead? I'm thinking that if that source is updated, we might end up with out-of-sync docs.

Copy link
Member

@vcanales vcanales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@juanmaguitar juanmaguitar merged commit a2f6e21 into WordPress:trunk Nov 9, 2022
@github-actions github-actions bot added this to the Gutenberg 14.6 milestone Nov 9, 2022
@juanmaguitar juanmaguitar changed the title Move "Available commands" section of create-package to a subpage Summarize "Available commands" section and refer them it to scripts docs Nov 9, 2022
Copy link
Contributor

@bangank36 bangank36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants