Plugin: Navigation menu doesn't appear when hamburger clicked on

[t-hamano]

Fixed reopened #33273

What?

This PR fixes a problem with the Gutenberg plugin enabled in a Windows environment where the modal doesn't appear when the navigation hamburger is clicked.

Why?

This problem is caused by /lib/compat/wordpress-6.1/blocks.php for backward compatibility.

My understanding is that the gutenberg_block_type_metadata_view_script function exists to load multiple viewScripts in the old WordPress version. And in the navigation block, view.min.js and view-modal.min.js, are specified as viewScripts.

In this function, the forward slash and backslash are mixed as path delimiters, which causes the problem that view-modal.min.js in the above script is not loaded.

@bobbingwide's analysis of this issue in this comment may also be helpful.

How?

Within this function, all path delimiters have been unified into forward slashes.
I will explain the details in turn in the comments that follow.

Testing Instructions

• Fork this PR into the plugin directory of your local Windows environment and build it.
• Confirm that both view.min.js and view-modal.min.js are loaded.
• Confirm that the modal is displayed when the hamburger is clicked.

Screenshots or screencast

[codesandbox]

  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

[vcanales]

Tested on Windows, LGTM.

[bobbingwide]

I haven't tested this myself yet. Does this solution work when Gutenberg is symlinked from a different folder?

[t-hamano]

@bobbingwide
Symlinks were not tested in this PR. This PR is intended to unify delimiters by OS, and I think the original issue didn't report whether Gutenberg is symlinked or not, or whether it causes any problems.

If the problem occurs when the Gutenberg project is symlinked, then it would be a good idea to submit a new issue.