List View - Stop child item selecting a parent which is already selected #45860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Some overlap/relatedness to #45794 |
|
Size Change: +15 B (0%) Total Size: 1.3 MB
ℹ️ View Unchanged
|
ajlende
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes a bug observed in the Offcanvas Navigation Editor to stop allowing list view child items' settings menu providing an option to select a parent block if that parent is already selected.
This was manifesting as the popover disappearing when attempting to mouseover the option. See screenshots.
Why?
Rendering a List View within a block is a new pattern. This has exposed the above bug whereby the menu says
Select parent blockbut the parent block is already selected. That's not something we wish to expose.How?
This checks whether the currently selected block matches the parent block ID and if it does then it doesn't show the Select Parent option.
Testing Instructions
Also check that the "Select parent" feature still works for the main list view for normal blocks.
Screenshots or screencast
Before
Screen.Capture.on.2022-11-17.at.15-57-08.mp4
After