Navigation List view: fix incorect class #46129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaggieCabrera
assigned draganescu, scruffian, getdave and ajlende and unassigned draganescu, getdave, ajlende and scruffian
MaggieCabrera
requested review from
scruffian,
getdave,
ajlende and
draganescu
draganescu
approved these changes
Nov 28, 2022
|
Size Change: +1 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
During the code review fixes of #45966 the final class we are using is not the correct one.
Why?
The CSS is not being applied and the list view doesn't scroll
Testing Instructions
With the Navigation List view experiment on, test a navigation menu that has multiple sub menus and overflows horizontally. The scroll should only affect the list view, not the whole sidebar.
Screenshots or screencast