WP Webfonts: avoid duplicated font families if the font family name was defined using fallback values. #46378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
WP Webfonts: avoid duplicated font families if the font family name was defined using fallback values
Why?
Because of #46376
How?
The function
gutenberg_add_registered_webfonts_to_theme_jsonis adding the fonts twice when the font family name has fallback values. This is because how are we compairing the slug of the fonts.In this PR, we change the
get_font_slug functionto return the family slug if it is already defined. If it's not defined, the function returns the font family name. If the font family has fallback values, it creates the slug using the first font family name.Testing Instructions
Follow test instructions from: #46376
And see that the font is no longer repeated
Fixes: #46376