Add page list to Link UI transforms in Nav block #46426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
changed the title
getdave
commented
Dec 9, 2022
|
Size Change: -2 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
getdave
force-pushed
the
try/add-page-list-to-offcanvas-link-ui-transforms
branch
from
6804681 to
c9621e5
Compare
This comment was marked as resolved.
This comment was marked as resolved.
getdave
requested review from
scruffian,
MaggieCabrera,
draganescu and
ajlende
getdave
added
[Block] Navigation
getdave
force-pushed
the
try/add-page-list-to-offcanvas-link-ui-transforms
branch
from
c9621e5 to
7be304a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
getdave
added
[Block] Navigation Link
getdave
changed the title
getdave
deleted the
try/add-page-list-to-offcanvas-link-ui-transforms
branch
getdave
commented
Dec 14, 2022
Comment on lines
+77
to
+82
| 'core/page-list', | ||
| 'core/site-logo', | ||
| 'core/social-links', | ||
| 'core/search', | ||
| ]; | ||
|
|
There was a problem hiding this comment.
Let's shared this across all these blocks as a standard piece of config
dmsnell
pushed a commit
that referenced
this pull request
Dec 15, 2022
* Initial work * Remove debugging * Allow Page List in Nav Link and Submenu * Fix introduction of bug * Remove console log
This was referenced Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds Page List as a transform to link item blocks on the Nav block.
Why?
Enables flow where user wants to insert a Page List. Currently this isn't possible as the Custom Link block is always auto inserted when using the offcanvas.
How?
Adds relevant transforms.
Testing Instructions
+in inserter.Link UITransformsat bottom of Link UIPage List.Testing Instructions for Keyboard
Screenshots or screencast
Screen.Capture.on.2022-12-13.at.10-38-06.mp4