Fixed incorrect type annotations in @wordpress/data #46881
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR modifies several type annotations in the
data
package so that they don't throw errors when used in a TS codebase. The errors are mainly due to type constraints not being satisfied in templated types.This PR fixes #46626.
How?
Mostly I just added the needed type constraints to the affected type annotations. In the case of the
select()
anddispatch()
functions, I added a new@type
annotation, but I am not sure whether to remove the (now redundant)@param
and@return
annotations.Testing Instructions
Important notice
I have not been able to test this PR directly due to #46652. I have manually modified the built types to fix the issue and then applied the fixes from the build artifacts to the source code. Could you please test this before merging?