Navigation: Remove ghost inserter #46919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
requested review from
draganescu,
getdave,
MaggieCabrera and
ajlende
|
Size Change: +15 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in eb05095. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3848492784
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This removes the "ghost" inserter that appears around the innerBlocks for the navigation link block. This was introduced in #45906.
Fixes #46574
Why?
Cleans up the UI.
How?
By adding a
remove-outlineclass to innerBlocksProps, and removing all other classes. I'm not sure if this is the best way, but every other approach I took didn't work.Testing Instructions
Testing Instructions for Keyboard
Check that items within a navigation block can still be reordered using the keyboard.
Screenshots or screencast
Before:
After:
