Template Parts: Avoid duplicate titles on creation #46996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to ensure that there is no duplicate title. If there is, add a suffix.
apeatling
added
[Status] In Progress
|
Size Change: +68 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in d424584. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3879006808
|
jameskoster
reviewed
Jan 10, 2023
There was a problem hiding this comment.
Works 👍
The other option here would be to validate the inputs on submit, and alert the user if the chosen name is already in use.
I think this is probably better though as it eliminates any friction in the creation flow, and it's generally an edge case anyway.
jameskoster
approved these changes
Jan 10, 2023
|
Thanks 👍 Will follow up with a PR to address converting and naming a group of blocks to a template part. |
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #42473. Do not allow duplicate titles for template parts when creating a new template part in the UI. Instead add an iterator suffix as is done with slugs.
Why?
See #42473 for images. Essentially we don't want users to have a huge list of template parts all with the same name in the UI. It becomes impossible to pick the correct one.
How?
I perform this on the client side at creation time, although I'm wondering if a filter on the PHP side would be a better approach? Interested in thoughts.
The same thing needs to happen on conversion of a group of blocks to a template part, this is not yet handled. This would mean needing to separate out the client side code to be used in two separate components. If this is switched to a PHP filter it would just happen automatically, everywhere.
Testing Instructions