Block Editor: Move component styles needed for iframes to content styles #47103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +254 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
t-hamano
added
[Type] Bug
|
Flaky tests detected in 249ea8d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3908139167
|
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on: #44298
What?
This PR moves some of the block editor component styles to be applied to the iframe editor instance. This will ensure that the styles of some components are applied correctly.
Why?
In #44298, some component styles in the block editor package are now split and loaded into the iframe editor instance.
However, I think the following component styles should be loaded into the iframe:
block-variation-picker: Used for variation pickers like the column blockwarning: Used for UI to recover when a block is brokenblock-icon: Used for the title icon of the placeholder componentHow?
I moved
block-variation-pickerandwarningfromstyle.csstocontent.css. Forblock-icon, I copiedstyle.cssand createdcontent.csssince it is also used in the sidebar.Testing Instructions
Paste the following markup into the editor and confirm that the styles are applied correctly.
Test Data
Screenshots or screencast