-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fonts API] Remove local() from @font-face styles. #47254
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Luehrsen Are you available to test this? |
aristath
approved these changes
Jan 18, 2023
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Feb 13, 2023
…nts_handler(). Removes adding `local()` as a `@font-face` `src` within `_wp_theme_json_webfonts_handler()`. Why? To fix font incompatibilities when a user has the font-family locally installed on their viewing computer or device. It's unknown if all of the font-face variations specified by theme.json and/or global styles are: * installed on the user's computer/device. * and in one file or multiple files. The previous implementation used the `src` specified when registering the font with the API. That src will likely vary from user computer/device to user computer/device. To avoid these unknowns which could cause incompatibilities or styling issues, this changeset removes adding `local()` to the generated font-face CSS styles. References: * [WordPress/gutenberg#47254 Gutenberg PR 47254] Follow-up to [53282]. Props luehrsen, aristath, ehtmlu, hellofromTonya, wetah. Fixes #57430. git-svn-id: https://develop.svn.wordpress.org/trunk@55314 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Feb 13, 2023
…nts_handler(). Removes adding `local()` as a `@font-face` `src` within `_wp_theme_json_webfonts_handler()`. Why? To fix font incompatibilities when a user has the font-family locally installed on their viewing computer or device. It's unknown if all of the font-face variations specified by theme.json and/or global styles are: * installed on the user's computer/device. * and in one file or multiple files. The previous implementation used the `src` specified when registering the font with the API. That src will likely vary from user computer/device to user computer/device. To avoid these unknowns which could cause incompatibilities or styling issues, this changeset removes adding `local()` to the generated font-face CSS styles. References: * [WordPress/gutenberg#47254 Gutenberg PR 47254] Follow-up to [53282]. Props luehrsen, aristath, ehtmlu, hellofromTonya, wetah. Fixes #57430. Built from https://develop.svn.wordpress.org/trunk@55314 git-svn-id: http://core.svn.wordpress.org/trunk@54847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to gilzow/wordpress-performance
that referenced
this pull request
Feb 13, 2023
…nts_handler(). Removes adding `local()` as a `@font-face` `src` within `_wp_theme_json_webfonts_handler()`. Why? To fix font incompatibilities when a user has the font-family locally installed on their viewing computer or device. It's unknown if all of the font-face variations specified by theme.json and/or global styles are: * installed on the user's computer/device. * and in one file or multiple files. The previous implementation used the `src` specified when registering the font with the API. That src will likely vary from user computer/device to user computer/device. To avoid these unknowns which could cause incompatibilities or styling issues, this changeset removes adding `local()` to the generated font-face CSS styles. References: * [WordPress/gutenberg#47254 Gutenberg PR 47254] Follow-up to [53282]. Props luehrsen, aristath, ehtmlu, hellofromTonya, wetah. Fixes #57430. Built from https://develop.svn.wordpress.org/trunk@55314 git-svn-id: https://core.svn.wordpress.org/trunk@54847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
VenusPR
added a commit
to VenusPR/Wordpress_Richard
that referenced
this pull request
Mar 9, 2023
…nts_handler(). Removes adding `local()` as a `@font-face` `src` within `_wp_theme_json_webfonts_handler()`. Why? To fix font incompatibilities when a user has the font-family locally installed on their viewing computer or device. It's unknown if all of the font-face variations specified by theme.json and/or global styles are: * installed on the user's computer/device. * and in one file or multiple files. The previous implementation used the `src` specified when registering the font with the API. That src will likely vary from user computer/device to user computer/device. To avoid these unknowns which could cause incompatibilities or styling issues, this changeset removes adding `local()` to the generated font-face CSS styles. References: * [WordPress/gutenberg#47254 Gutenberg PR 47254] Follow-up to [53282]. Props luehrsen, aristath, ehtmlu, hellofromTonya, wetah. Fixes #57430. Built from https://develop.svn.wordpress.org/trunk@55314 git-svn-id: http://core.svn.wordpress.org/trunk@54847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42190
Core Trac https://core.trac.wordpress.org/ticket/57430
What?
Removes adding
local()
as a@font-face
src
.Why?
From the issue:
From the Trac ticket:
Testing Instructions
Testing instructions are in the issue's description. The expected results:
Before the PR:
after the PR: