Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shadow: rename shadow palette to presets #47272

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Shadow: rename shadow palette to presets #47272

merged 1 commit into from
Jan 19, 2023

Conversation

madhusudhand
Copy link
Member

Why?

Rename shadow => palette to shadow => presets to give more meaning.
It has no effect from previous behavior.

The new definition of the shadow presets changes to

"shadow": {
	"defaultPresets": true,
	"presets": [{
		"name": "Demo shadow",
		"slug": "demo-shadow",
		"shadow": "5px 5px 0 0 black"
	}]
},

scruffian
scruffian approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@scruffian scruffian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scruffian scruffian enabled auto-merge (squash) January 19, 2023 09:33
@github-actions
Copy link

Flaky tests detected in c39a2a5.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3957013612
📝 Reported issues:

@scruffian scruffian merged commit 3eb0586 into trunk Jan 19, 2023
@scruffian scruffian deleted the rename-shadow-palette branch January 19, 2023 09:58
@github-actions github-actions bot added this to the Gutenberg 15.1 milestone Jan 19, 2023
@bgardner bgardner mentioned this pull request Jan 19, 2023
Closed
This was referenced Jan 25, 2023
Closed
Closed
@juanmaguitar juanmaguitar added the [Type] Enhancement A suggestion for improvement. label Feb 1, 2023
pento pushed a commit to WordPress/wordpress-develop that referenced this pull request Feb 1, 2023
@hellofromtonya
Themes: Add shadow presets support for theme.json.
7374cde 
Adds shadow presets support for `theme.json` within the `WP_Theme_JSON` by 

* Adding it to presets metadata and valid settings.
* Defining the default shadow presets in Core's `theme.json`.

Includes PHPUnit tests. 

References:
* [WordPress/gutenberg#46813 Gutenberg PR 46813]
* [WordPress/gutenberg#47272 Gutenberg PR 47272]

Follow-up to [54162], [52049], [50973].

Props madhudollu, mamaduka, oandregal, scruffian, hellofromTonya.
Fixes #57559.

git-svn-id: https://develop.svn.wordpress.org/trunk@55176 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Feb 1, 2023
@hellofromtonya
Themes: Add shadow presets support for theme.json.
263ef55 
Adds shadow presets support for `theme.json` within the `WP_Theme_JSON` by 

* Adding it to presets metadata and valid settings.
* Defining the default shadow presets in Core's `theme.json`.

Includes PHPUnit tests. 

References:
* [WordPress/gutenberg#46813 Gutenberg PR 46813]
* [WordPress/gutenberg#47272 Gutenberg PR 47272]

Follow-up to [54162], [52049], [50973].

Props madhudollu, mamaduka, oandregal, scruffian, hellofromTonya.
Fixes #57559.
Built from https://develop.svn.wordpress.org/trunk@55176


git-svn-id: http://core.svn.wordpress.org/trunk@54709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot pushed a commit to platformsh/wordpress-performance that referenced this pull request Feb 1, 2023
@hellofromtonya
Themes: Add shadow presets support for theme.json.
3315303 
Adds shadow presets support for `theme.json` within the `WP_Theme_JSON` by 

* Adding it to presets metadata and valid settings.
* Defining the default shadow presets in Core's `theme.json`.

Includes PHPUnit tests. 

References:
* [WordPress/gutenberg#46813 Gutenberg PR 46813]
* [WordPress/gutenberg#47272 Gutenberg PR 47272]

Follow-up to [54162], [52049], [50973].

Props madhudollu, mamaduka, oandregal, scruffian, hellofromTonya.
Fixes #57559.
Built from https://develop.svn.wordpress.org/trunk@55176


git-svn-id: https://core.svn.wordpress.org/trunk@54709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
VenusPR added a commit to VenusPR/Wordpress_Richard that referenced this pull request Mar 9, 2023
@VenusPR
Themes: Add shadow presets support for theme.json.
0302b5b 
Adds shadow presets support for `theme.json` within the `WP_Theme_JSON` by 

* Adding it to presets metadata and valid settings.
* Defining the default shadow presets in Core's `theme.json`.

Includes PHPUnit tests. 

References:
* [WordPress/gutenberg#46813 Gutenberg PR 46813]
* [WordPress/gutenberg#47272 Gutenberg PR 47272]

Follow-up to [54162], [52049], [50973].

Props madhudollu, mamaduka, oandregal, scruffian, hellofromTonya.
Fixes #57559.
Built from https://develop.svn.wordpress.org/trunk@55176


git-svn-id: http://core.svn.wordpress.org/trunk@54709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scruffian scruffian scruffian approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

@ajlende ajlende Awaiting requested review from ajlende

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees
No one assigned
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 15.1
Development

Successfully merging this pull request may close these issues.
3 participants
@madhusudhand @scruffian @juanmaguitar