Post Template: Add default value for offset
#47308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +174 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
t-hamano
added
[Type] Bug
ntsekouras
reviewed
Jan 20, 2023
There was a problem hiding this comment.
Thanks for the PR!
I think it would be simpler to just add 0 as a default value here and it would align with front end handling here.
What do you think?
t-hamano
changed the title
offset and perPageoffset
|
@ntsekouras The reason I implemented this is that I felt that simply adding default values would not prevent non-numeric, illegal values from entering the query. However, this problem can occur with other query parameters as well, so it would have been better not to put in too much complexity 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #45867
What?
This PR
normalizes the values ofadds default value foroffsetandperPagequery parametersoffsetof the Post Template block in the editor.Why?
Query parameters in the Post Template block are inherited from the Query block. Then, within the query to be built, the
offsetproperty is calculated in the following part:gutenberg/packages/block-library/src/post-template/edit.js
Lines 123 to 124 in 2499646
This formula works correctly when the block is generated from a variation placeholder since all variations of the query block have an
offsetvalue.However, if a query block with the innerBlock is created as a variation, the placeholder is skipped and the content is rendered directly. As a result, if no offset is defined,
NaNis generated by the following formula:This will generate an incorrect request URL, as reported in #45867.
How?
I have rewritten the logic that generates these two values to be nearly identical to what PHP renders on the front end:Just adds default value for offset.
gutenberg/lib/compat/wordpress-6.1/blocks.php
Lines 190 to 206 in 2499646
As a result, if incorrect values are injected, these values are normalized and the incorrect request URL will not generated.
Testing Instructions
Use the following code to generate query variations with invalid parameters.
Insert this variation.
Before: An invalid request URL will be generated and the content will not be rendered.