[Block Editor]: Fix onHover errors at BlockPattern
#47466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
|
Size Change: +8 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 270497f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4017095702
|
t-hamano
approved these changes
Jan 27, 2023
There was a problem hiding this comment.
Thanks for the follow-up, @ntsekouras!
I have confirmed that this PR does not generate a browser console error when mousing over a block pattern list item for which onHover is not defined.
Mamaduka
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A small follow up for: #47316
BlockPattern component is used in more places where
onHoveris not defined. This PR fixes that. I didn't add a defaultnoopfunction, because I don't think there is the need to even call something if not defined.Testing Instructions
Patterns Explorerorreplace(block settings menu) in a Template Part