Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Block Patterns Controller PHPUnit tests #47569

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Update Block Patterns Controller PHPUnit tests #47569

merged 1 commit into from
Jan 30, 2023

Conversation

Mamaduka
Copy link
Member

@Mamaduka Mamaduka commented Jan 30, 2023 •
edited
Loading

What?

PR updates Block Patterns Controller tests to match the core and reduce noise when running them.

Why?

Use @doesNotPerformAssertions instead of $this->markTestIncomplete(); when controlled doesn't implement the method.

Testing Instructions

CI is green.

npm run test:unit:php -- --filter Gutenberg_REST_Block_Patterns_Controller_6_2_Test

@Mamaduka Mamaduka self-assigned this Jan 30, 2023
@Mamaduka Mamaduka added [Type] Code Quality Issues or PRs that relate to code quality Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced and removed Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Jan 30, 2023
@Mamaduka Mamaduka requested a review from ntsekouras January 30, 2023 16:48
@ntsekouras ntsekouras merged commit 46a5545 into trunk Jan 30, 2023
@ntsekouras ntsekouras deleted the update/block-patterns-controller-tests branch January 30, 2023 20:16
@github-actions github-actions bot added this to the Gutenberg 15.1 milestone Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntsekouras ntsekouras ntsekouras approved these changes

Assignees

@Mamaduka Mamaduka

Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 15.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Mamaduka @ntsekouras