Store: Remove redundant handling of inserter position #4765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To reflect that it merely represents a single boolean value: visible or not visible.
aduth
added
the
[Feature] Inserter
aduth
force-pushed
the
remove/redundant-sibling-inserter
branch
from
d3b9348 to
cbb5004
Compare
noisysocks
approved these changes
Jan 31, 2018
jasmussen
approved these changes
Jan 31, 2018
There was a problem hiding this comment.
Experience wise, this works for me.
As noted in #4669 (comment), we might still want to restore this sibling inserter and kill the side inserter, depending on feedback. But this makes for a more accurate test. Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocker for #3745
Related: #4539, #3745
See: #4539 (comment)
This pull request seeks to remove redundant handling of inserter position, relevant only for the sibling inserter which was removed in #4539. It also consequently reshapes the reducer state for insertion point, which now only needs to reflect a single value reflecting whether or not the insertion point is visible.
Testing instructions:
Repeat testing instructions from #4539.