Fix infinite render of inline block preview #47697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -11 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7b7050a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4100516711
|
mikachan
approved these changes
Feb 3, 2023
talldan
added
[Type] Bug
madhusudhand
force-pushed
the
fix-inline-preview
branch
from
fffc193 to
7b7050a
Compare
ntsekouras
reviewed
Feb 6, 2023
| import { __experimentalSpacer as Spacer } from '@wordpress/components'; | ||
|
|
||
| const BlockPreviewPanel = ( { name, variation = '' } ) => { | ||
| const [ |
There was a problem hiding this comment.
Hm.. why we needed useResizeObserver in the first place here?
There was a problem hiding this comment.
To set the min-height of the preview iframe container, so that block preview (like button) is vertically center aligned.
It was captured using useResizeObserver, but seems like it was a bad idea for non-floating scrollbars that change with and height when they appear on content overflow.
t-hamano
approved these changes
Feb 6, 2023
There was a problem hiding this comment.
LGTM 👍
✅ Image, Calendar, Latest Comments: Infinite loop doesn't occur
✅ Table: If viewportWidth is defined with example, It will still be displayed as before.
✅ Button: It will be displayed in the center as before.
✅ Quote: If the block is less than the height of the preview area, the scroll bar will not be displayed as before.
ef06150b60678e27b950a381e07b4920.mp4
|
Cherry-picked this PR to the wp/6.2 branch. |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This fixes #46793 where inline preview re-renders infinitely.
Issue happens for blocks such as
Testing Instructions
Issue happens when scrollbar is always visible.
Operating system settings:
Windows: scrollbar is visible by default.
Mac: System Preferences -> General -> show scrollbars (set the value to always)
Screenshots or screencast
Before
After