Lodash: Refactor away from _.mapValues() in data registry
#47742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
Mamaduka,
sgomes,
aristath,
jsnajdr,
swissspidy,
flootr,
chad1008,
ntsekouras,
fabiankaegy and
brookewp
|
Size Change: +6 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
tyxla
commented
Feb 3, 2023
| }; | ||
| } ); | ||
| return Object.fromEntries( | ||
| Object.entries( attributes ).map( ( [ key, attribute ] ) => { |
There was a problem hiding this comment.
Will always be a properly defined registry object:
gutenberg/packages/data/src/registry.js
Line 354 in 3bc98f0
gutenberg/packages/data/src/registry.js
Line 312 in 3bc98f0
ntsekouras
approved these changes
Feb 3, 2023
|
Flaky tests detected in 57ad6bc. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4085269675
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash's
_.mapValues()from the@wordpress/dataregistry creation module. There is just a single use in that module and conversion is pretty straightforward.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're replacing
_.mapValues()withObject.fromEntries( Object.entries().map() ).Testing Instructions