Fix Post Excerpt: Read more link is always on new line in the editor #47772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinan
added
[Block] Post Excerpt
|
Size Change: -2 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in a2ba780. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4102207267
|
|
It is a shame that was an option in the first place. Block level links are always better for accessibility. 👎 Inline links can be rather confusing as they can blend in with content. The display property in CSS is pretty much the only one used by screen readers. |
alexstine
approved these changes
Feb 6, 2023
|
@iamtakashi I would be OK with the editor and front not matching in this case, if it means it is more accessible. |
|
@carolinan I was talking about both. Inline links are tricky on both the front or back because of this. This is an example of how screen readers interpret this. Block:
Users navigating in virtual mode will arrow down to get the text and another arrow down will land them on the link. Inline:
Users navigating with down arrow key will get the paragraph and link all in one go forcing users to use the link command or tab to focus the link at the end of the paragraph. It is kind of too late now to fix this I think without deprecating the option. Just something to think about for the future mostly. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes the read more link position in the post excerpt block.
When the option "Show link on new line" is toggled off, the link should not be on a new line.
Closes #47458
Why?
In the editor, the read more link was always on a new line, if there was an excerpt text.
How?
Updates the CSS for the post excerpt, replaces
display: inline-blockwithdisplay:inlineTesting Instructions
(Exceptions are possible if there is no room for the texts to be on the same line).
Screenshots or screencast
After:
https://user-images.githubusercontent.com/7422055/216935918-500c8e6b-4d47-47ee-abc7-a490d6dbe527.mov