Update: Make OffCanvasEditor use LeafMoreMenu by default. #47844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
requested review from
ellatrix and
tellthemachines
as code owners
jorgefilipecosta
force-pushed
the
update/make-OffCanvasEditor-use-LeafMoreMenu-by-default
branch
from
450b495 to
b02c606
Compare
|
Size Change: +257 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 41b6fba. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4137356597
|
scruffian
reviewed
Feb 9, 2023
In that case, would an alternative approach where we keep the OffCanvasEditor as it is, but move LeafMoreMenu to the block editor packages as a locked experiment that is used by the navigation block and navigation sidebar work? I want to avoid LeafMoreMenu being duplicated and want to make sure the navigation sidebar and the navigation block have the same menu. |
That sounds ideal! |
jorgefilipecosta
force-pushed
the
update/make-OffCanvasEditor-use-LeafMoreMenu-by-default
branch
from
b02c606 to
0e5d52a
Compare
|
Hi @scruffian, I updated this PR to follow the discussed approach. |
jorgefilipecosta
force-pushed
the
update/make-OffCanvasEditor-use-LeafMoreMenu-by-default
branch
from
84339ae to
41b6fba
Compare
jorgefilipecosta
deleted the
update/make-OffCanvasEditor-use-LeafMoreMenu-by-default
branch
DaisyOlsen
added
[Package] Block library
juanmaguitar
added
[Type] Enhancement
ntsekouras
added
the
Backport to WP 6.7 Beta/RC
ntsekouras
pushed a commit
that referenced
this pull request
Feb 21, 2023
|
Cherry-picked this PR to the wp/6.2 branch. |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes OffCanvasEditor use LeafMoreMenu by default.
We have two use cases of OffCanvasEditor and in both of them we want to use LeafMoreMenu so the items match. I think we can avoid a property for custom menus until we have a case where we we need something different from this default.
This change also reduces the items that appear on the navigation sidebar.
cc: @draganescu, @scruffian