Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync: Widget import changes from the core #47875

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

Mamaduka
Copy link
Member

@Mamaduka Mamaduka commented Feb 8, 2023

What?

Sync changes from WordPress/wordpress-develop#3893, to avoid registering sidebars twice.

  • Changes registration method and theme mod name.

Testing Instructions

See #45509

  1. Active a classic theme.
  2. Insert widgets into the sidebars.
  3. Switch to the block theme.
  4. Open a template in the Site Editor.
  5. Add a new template part to the template.
  6. Import widgets.

@Mamaduka Mamaduka self-assigned this Feb 8, 2023
@Mamaduka Mamaduka added [Type] Task Issues or PRs that have been broken down into an individual action to take [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. labels Feb 8, 2023
@Mamaduka Mamaduka requested a review from ntsekouras February 8, 2023 12:37
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

Flaky tests detected in ef91644.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4124050729
📝 Reported issues:

@Mamaduka Mamaduka merged commit dcfdba8 into trunk Feb 8, 2023
@Mamaduka Mamaduka deleted the sync/widget-import-core-changes branch February 8, 2023 12:50
@github-actions github-actions bot added this to the Gutenberg 15.2 milestone Feb 8, 2023
@juanmaguitar juanmaguitar added the [Type] Code Quality Issues or PRs that relate to code quality label Feb 15, 2023
@juanmaguitar juanmaguitar mentioned this pull request Feb 15, 2023
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Code Quality Issues or PRs that relate to code quality [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants