-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply keyboard shortcut conversions between paragraphs and headings to all editor instances #47972
Merged
Merged
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
54dff7d
Apply keyboard shortcut conversions between paragraphs and headings t…
t-hamano a1930fd
Try to fix e2e tests
t-hamano 8de59ab
Try to fix e2e tests
t-hamano a356222
Add comment
t-hamano 2c8ea0b
Remove unnecessary files
t-hamano 6ea9ed3
Use toMatchObject instead of toBe
t-hamano a0f6010
Temporarily apply #48093 changes
t-hamano 5acc31c
Fix test
t-hamano b960296
Merge branch 'trunk' into enhancement/paragraph-top-heading-shortcut
t-hamano c093e75
Merge branch 'trunk' into enhancement/paragraph-top-heading-shortcut
t-hamano f7e0a41
Merge branch 'trunk' into enhancement/paragraph-top-heading-shortcut
t-hamano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -70,15 +70,18 @@ function KeyboardShortcuts() { | |
if ( blockName !== 'core/paragraph' && blockName !== 'core/heading' ) { | ||
return; | ||
} | ||
const currentAttributes = getBlockAttributes( currentClientId ); | ||
const { content: currentContent, align: currentAlign } = | ||
currentAttributes; | ||
const attributes = getBlockAttributes( currentClientId ); | ||
const textAlign = | ||
blockName === 'core/paragraph' ? 'align' : 'textAlign'; | ||
const destinationTextAlign = | ||
destinationBlockName === 'core/paragraph' ? 'align' : 'textAlign'; | ||
|
||
replaceBlocks( | ||
currentClientId, | ||
createBlock( destinationBlockName, { | ||
level, | ||
content: currentContent, | ||
align: currentAlign, | ||
content: attributes.content, | ||
...{ [ destinationTextAlign ]: attributes[ textAlign ] }, | ||
} ) | ||
); | ||
}; | ||
|
@@ -181,7 +184,7 @@ function KeyboardShortcuts() { | |
} ); | ||
|
||
registerShortcut( { | ||
name: `core/block-editor/transform-heading-to-paragraph`, | ||
name: `core/edit-post/transform-heading-to-paragraph`, | ||
Comment on lines
-184
to
+187
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the namespace should be unified. |
||
category: 'block-library', | ||
description: __( 'Transform heading to paragraph.' ), | ||
keyCombination: { | ||
|
@@ -192,7 +195,7 @@ function KeyboardShortcuts() { | |
|
||
[ 1, 2, 3, 4, 5, 6 ].forEach( ( level ) => { | ||
registerShortcut( { | ||
name: `core/block-editor/transform-paragraph-to-heading-${ level }`, | ||
name: `core/edit-post/transform-paragraph-to-heading-${ level }`, | ||
category: 'block-library', | ||
description: __( 'Transform paragraph to heading.' ), | ||
keyCombination: { | ||
|
@@ -257,17 +260,16 @@ function KeyboardShortcuts() { | |
} | ||
} ); | ||
|
||
useShortcut( | ||
'core/block-editor/transform-heading-to-paragraph', | ||
( event ) => handleTextLevelShortcut( event, 0 ) | ||
useShortcut( 'core/edit-post/transform-heading-to-paragraph', ( event ) => | ||
handleTextLevelShortcut( event, 0 ) | ||
); | ||
|
||
[ 1, 2, 3, 4, 5, 6 ].forEach( ( level ) => { | ||
//the loop is based off on a constant therefore | ||
//the hook will execute the same way every time | ||
//eslint-disable-next-line react-hooks/rules-of-hooks | ||
useShortcut( | ||
`core/block-editor/transform-paragraph-to-heading-${ level }`, | ||
`core/edit-post/transform-paragraph-to-heading-${ level }`, | ||
( event ) => handleTextLevelShortcut( event, level ) | ||
); | ||
} ); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heading block and paragraph block have different property name for text alignment:
textAlign
align
Therefore, property name and value must be properly mapped.