Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: Change higher order with-constraint-tabbing from .js to .tsx #48162

Merged
merged 4 commits into from
Feb 28, 2023
Merged

Update: Change higher order with-constraint-tabbing from .js to .tsx #48162

merged 4 commits into from
Feb 28, 2023

Conversation

hbhalodia
Copy link
Contributor

@hbhalodia hbhalodia commented Feb 17, 2023 •
edited
Loading

What?

  • PR Changes .js file to .tsx

Why?

How?

  • Changed to .tsx file and pass the build process.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Feb 17, 2023
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @hbhalodia! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@mirka mirka self-requested a review February 27, 2023 10:14
@hbhalodia hbhalodia marked this pull request as ready for review February 28, 2023 05:47
@hbhalodia hbhalodia requested a review from ajitbohra as a code owner February 28, 2023 05:47
@mirka mirka changed the title Update: Chnage higher order with-constraint-tabbing from .js to .tsx Update: Change higher order with-constraint-tabbing from .js to .tsx Feb 28, 2023
@mirka mirka mentioned this pull request Feb 28, 2023
Closed
mirka
mirka reviewed Feb 28, 2023
View reviewed changes
Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you for contributing!

Let's also copy and paste the main README description into a JSDoc so it can be shown in IntelliSense in IDEs 👉 601f7f7

And if you could add a brief changelog under the "Internal" section before merging, that would be great 🙏

@hbhalodia
Copy link
Contributor Author

Hi @mirka, The above comment has been addressed. Thanks.

@hbhalodia hbhalodia requested review from mirka and removed request for ajitbohra February 28, 2023 11:56
mirka
mirka approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! 🚢

@mirka mirka merged commit d899945 into WordPress:trunk Feb 28, 2023
@github-actions
Copy link

Congratulations on your first merged pull request, @hbhalodia! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 15.3 milestone Feb 28, 2023
@ciampo ciampo added [Type] Code Quality Issues or PRs that relate to code quality [Package] Components /packages/components labels Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirka mirka mirka approved these changes

Assignees

@hbhalodia hbhalodia

Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 15.3
Development

Successfully merging this pull request may close these issues.
3 participants
@hbhalodia @mirka @ciampo