Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Editor Handbook: Improved the readability and phrasing and corrected mistakes #48756

Merged
merged 2 commits into from
Mar 24, 2023

Conversation

tomdevisser
Copy link
Member

@tomdevisser tomdevisser commented Mar 5, 2023

Corrected weird and awkward phrasings and sentences, and made some things more specific.

Some examples and thoughts behind the changes:
Why would the Block Editor documentation link to the Block Editor documentation. I'm already there right? We're linking to the How-To guides.

Or why do we write Block Inserter capitalized, but not Block Editor?

Sometimes the order of words was just plain weird. "you will find here guides to help you"

There was a quick link, just before the heading Quick Links, which didn't make sense to me. Also, it's one of the first links in the documentation and it links away from the documentation to a support article so that asks for a bit more context. Clearly stating you're going away from dev focussed content to end-user focussed content.

Corrected weird and awkward phrasings and sentences, and made some things more specific.

Some examples and thoughts behind the changes:
Why would the Block Editor documentation link to the Block Editor documentation. I'm already there right? We're linking to the How-To guides.

Or why do we write Block Inserter capitalized, but not Block Editor?

Sometimes the order of words was just plain weird. "you will find here guides to help you"

There was a quick link, just before the heading Quick Links, which didn't make sense to me. Also, it's one of the first links in the documentation and it links away from the documentation to a support article so that asks for a bit more context. Clearly stating you're going away from dev focussed content to end-user focussed content.
@tomdevisser tomdevisser changed the title Improved the readability and phrasing and corrected mistakes Block Editor Handbook: Improved the readability and phrasing and corrected mistakes Mar 5, 2023
@tomdevisser tomdevisser self-assigned this Mar 5, 2023
@tomdevisser tomdevisser added the [Type] Developer Documentation Documentation for developers label Mar 5, 2023
@alexstine alexstine requested a review from annezazu March 7, 2023 03:59
@alexstine
Copy link
Contributor

The whole case issue around Gutenberg is really annoying. I have seen this problem too. Some is an uppercase letter for each word and some is sentence format.

@tomdevisser
Copy link
Member Author

The whole case issue around Gutenberg is really annoying.

I agree, wonder how this is handled in WordPress docs. Might need a global document where we define what gets capitalized and what doesn't. I also see Block and block everywhere, same goes for Editor and editor.

@tomdevisser tomdevisser requested a review from ryanwelcher March 10, 2023 17:32
Copy link
Contributor

@ryanwelcher ryanwelcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change then I think we're good to go!

@tomdevisser tomdevisser requested a review from ryanwelcher March 10, 2023 17:55
Copy link
Contributor

@ryanwelcher ryanwelcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@aristath aristath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
There was a failing test preventing this from getting merged but it's not related this PR, so I restarted the test and once it passes we can merge this 👍

@aristath aristath merged commit 17dfc83 into WordPress:trunk Mar 24, 2023
@github-actions github-actions bot added this to the Gutenberg 15.5 milestone Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants