Data: Use real timers for private APIs tests #49029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Code Quality
|
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
|
Flaky tests detected in b40d1d4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4405456465
|
ntsekouras
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
While looking at the private API tests for
@wordpress/dataI noticed that we're using fake timers without a good reason to do so. This PR removes them and that way it defaults to using the real timers.Why?
It's not necessary for those tests to run with fake timers.
How?
We're just disabling the fake timers and the cleanup to revert to real timers. We're also removing a stray imports doc block.
Testing Instructions
Verify tests still pass.
Testing Instructions for Keyboard
None.
Screenshots or screencast
None.