CustomGradientPicker: improve initial state UI #49146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +117 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Mar 17, 2023
chad1008
reviewed
Mar 17, 2023
There was a problem hiding this comment.
Nice, I like this change a lot. Really simplifies parsing what the utility is actually accomplishing.
| // Control points color option may be hex from presets, custom colors will be rgb. | ||
| // The position should always be a percentage. | ||
| const controlPoints = gradientAST.colorStops.map( ( colorStop ) => { | ||
| return { | ||
| color: getStopCssColor( colorStop ), | ||
| // Although it's already been checked by `hasUnsupportedLength` in `getGradientAstWithDefault`, | ||
| // Although it's already been checked by `hasUnsupportedLength` in `getGradientAst`, |
There was a problem hiding this comment.
I notice you've changed this comment, but the function returning gradientAST is still named getGradientAstWithDefault. Did you mean to rename the function now that it's handling default gradients differently?
There was a problem hiding this comment.
I did rename the function at some point, but then I changed my mind and restored the original name. Although I forgot to update the comment — thank you for catching it!
Base automatically changed from
refactor/CustomGradientPicker-typescript
to
trunk
March 17, 2023 15:32
ciampo
force-pushed
the
fix/color-picker-updates-in-gradients
branch
from
af93646 to
3e2dea4
Compare
|
Flaky tests detected in 3e2dea4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4449184008
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Requires #48929 to be merged first
Part of #42994
Improve
CustomGradientPicker's initial UI state and interaction:Why?
Improve the component's UX
How?
divelement dedicated to display thebackground-color, and applying some CSS changes to force the controls on the bottom row to render with a lower stacking index than the gradient barhasGradientlogic: previously the component would think that it didn't a gradient set if, as a coincidence, the user chose a gradient value that was the same as the default gradientTesting Instructions
Interact with the component on Storybook and in the editor (for example, in the Site Editor > Global Styles Sidebar > Colors > Palette > "Gradient" tab > Create a new custom gradient)
trunkScreenshots or screencast