Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @api-fetch README.md with query args #49318

Merged
merged 2 commits into from
Mar 28, 2023

Conversation

helgatheviking
Copy link
Contributor

@helgatheviking helgatheviking commented Mar 23, 2023

Additionally, explain that data is NOT included in a GET request.

What?

Clarify that data is not passed in a GET request

Why?

Because I just spent 4 hours wondering why the request was failing entirely and telling me I wasn't connected to the internet.

How?

This shows how to pass query args to a specific endpoint when using a GET request.

Additionally, explain that `data` is NOT included in a `GET` request.
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Mar 23, 2023
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @helgatheviking! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@skorasaurus skorasaurus added the [Type] Developer Documentation Documentation for developers label Mar 24, 2023
@Mamaduka Mamaduka merged commit 113e858 into WordPress:trunk Mar 28, 2023
@github-actions github-actions bot added this to the Gutenberg 15.5 milestone Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants