Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: fix incorrect import of apiFetch #49432

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Docs: fix incorrect import of apiFetch #49432

merged 1 commit into from
Mar 29, 2023

Conversation

t-hamano
Copy link
Contributor

@t-hamano t-hamano commented Mar 29, 2023 •
edited
Loading

This PR fixes the incorrect import description of apiFetch in How to Guides.

apiFetch is exported as default. Therefore, the named import causes an error.

@t-hamano t-hamano requested a review from adamziel March 29, 2023 10:47
@t-hamano t-hamano marked this pull request as ready for review March 29, 2023 10:47
fabiankaegy
fabiankaegy approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch :)

@fabiankaegy fabiankaegy enabled auto-merge (squash) March 29, 2023 10:57
@fabiankaegy fabiankaegy added the [Type] Developer Documentation Documentation for developers label Mar 29, 2023
@fabiankaegy fabiankaegy merged commit 57fe118 into trunk Mar 29, 2023
@fabiankaegy fabiankaegy deleted the doc/fix-apifetch-import branch March 29, 2023 11:11
@github-actions github-actions bot added this to the Gutenberg 15.5 milestone Mar 29, 2023
@github-actions
Copy link

Flaky tests detected in a46d05c.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4553103393
📝 Reported issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiankaegy fabiankaegy fabiankaegy approved these changes

@adamziel adamziel Awaiting requested review from adamziel

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

Assignees
No one assigned
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 15.5
Development

Successfully merging this pull request may close these issues.
2 participants
@t-hamano @fabiankaegy