Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcode: Prevent external styling of editing UI #49723

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Shortcode: Prevent external styling of editing UI #49723

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6942490
Shortcode: Prevent external styling of editing UI
Mamaduka Apr 11, 2023
33d2fc3
Disable resizing
Mamaduka Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 26 additions & 5 deletions packages/block-library/src/shortcode/editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,34 @@
[data-type="core/shortcode"] {
.block-editor-plain-text {
max-height: 250px;
}

&.components-placeholder {
min-height: 0;
}
}

// The editing view for the Shortcode block is equivalent to block UI.
// Therefore we increase specificity to avoid theme styles bleeding in.
.blocks-shortcode__textarea {
@include input-control;
font-family: $editor-html-font !important;
color: $gray-900 !important;
background: $white !important;
padding: $grid-unit-15 !important;
border: $border-width solid $gray-900 !important;
box-shadow: none !important;
border-radius: $radius-block-ui !important;
box-sizing: border-box;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I included the box-sizing to contain a text area inside the placeholder for some themes, like 2023.

Screeenshot

CleanShot 2023-04-11 at 20 04 44

max-height: 250px;
resize: none;

/* Fonts smaller than 16px causes mobile safari to zoom. */
font-size: $mobile-text-min-font-size !important;
@include break-small {
font-size: $default-font-size !important;
}

&:focus {
border-color: var(--wp-admin-theme-color) !important;
box-shadow: 0 0 0 ($border-width-focus - $border-width) var(--wp-admin-theme-color) !important;

// Windows High Contrast mode will show this outline, but not the box-shadow.
outline: 2px solid transparent !important;
}
}