Lodash: Remove from @wordpress/editor package
#49799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
Mamaduka,
youknowriad,
sgomes,
aristath,
jsnajdr,
gziolo,
swissspidy,
flootr,
chad1008,
ntsekouras and
fabiankaegy
tyxla
commented
Apr 13, 2023
| @@ -38,7 +33,7 @@ export function PostTemplate() { | |||
|
|
|||
| const { editPost } = useDispatch( editorStore ); | |||
|
|
|||
| if ( ! isViewable || isEmpty( availableTemplates ) ) { | |||
| if ( ! isViewable || ! Object.entries( availableTemplates ?? {} ).length ) { | |||
There was a problem hiding this comment.
availableTemplates could potentially be nullish, so we're falling back to an empty object before checking if it's empty. If not nullish, it is always an object.
There was a problem hiding this comment.
Have you considered using Object.keys? It creates a smaller array, so intuitively it should be less wasteful 🙂
Instead of the ?? {} suffix I'd consider writing isViewable || ! availableTemplates || ! Object.keys( ... ).length.
There was a problem hiding this comment.
Both are good suggestions, thanks 👍 Addressed in 2f1bf4d
| @@ -87,7 +82,7 @@ const createWithMetaAttributeSource = ( metaAttributes ) => | |||
| ] ) | |||
| ); | |||
|
|
|||
| if ( ! isEmpty( nextMeta ) ) { | |||
| if ( Object.entries( nextMeta ).length ) { | |||
There was a problem hiding this comment.
nextMeta is always an object as defined a few lines above (L71).
| @@ -115,7 +110,7 @@ function shimAttributeSource( settings ) { | |||
| .filter( ( [ , { source } ] ) => source === 'meta' ) | |||
| .map( ( [ attributeKey, { meta } ] ) => [ attributeKey, meta ] ) | |||
| ); | |||
| if ( ! isEmpty( metaAttributes ) ) { | |||
| if ( Object.entries( metaAttributes ).length ) { | |||
There was a problem hiding this comment.
metaAttributes is always an object, as defined a few lines above (L108).
|
Size Change: -6 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
jsnajdr
approved these changes
Apr 14, 2023
| @@ -38,7 +33,7 @@ export function PostTemplate() { | |||
|
|
|||
| const { editPost } = useDispatch( editorStore ); | |||
|
|
|||
| if ( ! isViewable || isEmpty( availableTemplates ) ) { | |||
| if ( ! isViewable || ! Object.entries( availableTemplates ?? {} ).length ) { | |||
There was a problem hiding this comment.
Have you considered using Object.keys? It creates a smaller array, so intuitively it should be less wasteful 🙂
Instead of the ?? {} suffix I'd consider writing isViewable || ! availableTemplates || ! Object.keys( ... ).length.
tyxla
force-pushed
the
remove/lodash-editor-package
branch
from
b538784 to
18ae886
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes the remaining Lodash from the
@wordpress/editorpackage and removes the unused dependency. There were just a few straightforwardisEmpty()usages.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're using
Object.entries( object ).lengthas an alternative, with a nullish coalescing fallback when necessary.Testing Instructions
_.mapValues()from editor package #49654 and verify they still work.