Update REST API Controller PHPUnit tests #50120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
requested review from
ntsekouras and
aristath
and removed request for
ntsekouras
Mamaduka
added
Gutenberg Plugin
aristath
approved these changes
Apr 27, 2023
|
Flaky tests detected in ce3eba0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4817112222
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Similar to #47502.
PR updates remaining REST API controller PHPUnit tests to match the core and reduce noise when running them.
Why?
It's easy to miss an actual PHP warning in all the noise.
How?
Use
@doesNotPerformAssertionsinstead of$this->markTestIncomplete();when the controller doesn't implement the method.Testing Instructions
CI should be green.
Screenshots or screencast