Update some visual details in the add-template modal(s) #50143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.64 kB (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
Thanks for all the attention to detail here. Just connecting the dots with this border feedback I gave here, it seems okay to keep the gray borders in the resting state, perhaps make them lighter, similar to style buttons. And then if it still works, just omit the borders from the hover state. |
|
Copy pasting my reply from the issue :)
|
|
@jasmussen how do you feel about this? add-template.mp4 |
|
I liked the big buttons, but acknowledge they only work with the gray borders, which I still like. Big tappable buttons, even in their resting state, not just on hover. It's not the strongest opinion in the world, and I do appreciate that the hover state of the list-items now line up. But it might still be good to look at this button type in the larger range of things we want to do with page and template modals, it might work converting it all to lists here, but we might still need the larger buttons elsewhere. Normally I agree the borders add noise, in this case, I think it's about managing the whitespace. |
This reverts commit 6f4cc2c.
|
Okay let's disagree and commit 😁 |
|
Flaky tests detected in 53a85c8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4863283684
|
jasmussen
approved these changes
May 3, 2023
|
Ooops, the revert above removed the negative margins on the suggestions list that I added to line things up in that view. I just added those back:
I'll merge when the checks pass. |
bph
added
[Feature] Template Editing Mode
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #50134.
Updates the appearance of the add-template modal contents to be consistent with itself, and other parts of the UI.
In the first step, the buttons are now more closely aligned to similar button styles, IE any
tertiarybutton variants, and blocks in the Inserter.The list items in the second step now resemble the suggestions in the Command Center.
How?
Mostly css. Plus a couple of instances of the
Textcomponent.Side note: We should update the
Textcomponent to include the correct line-height on thebodysize.Testing Instructions
Before
before.mp4
After
add-template-appearance.mp4