Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image: Add lightbox using directives. #50373
Image: Add lightbox using directives. #50373
Changes from all commits
bd53de2
bd43bf6
e1dd737
8b84a22
d5dbc1c
037d669
8f62d34
62b6217
edfd7d1
8ee4065
594224b
fd6fe36
da4a5ad
2958fd1
0a68bea
fd08928
4e03e0d
92b6e6c
ffa881e
99c964b
7f7db2c
5e5ff9a
ad20b64
d16266b
0982d9f
0ef7b5e
e75fd87
f6414f9
31c0623
ee3701f
a0ac748
1dd6df1
a737200
3fd9270
5a9748c
9a6b1f2
1c7f6d5
470f74f
bba7c2d
2cb348c
c65bc57
1c655f7
697c04f
d4fd9d9
a57d634
234a8b6
4bef633
7aa7231
1d923ab
aee908a
33cb62d
55e37a3
d4d657b
8d6b0d0
76b2a75
70e51cd
e69833b
9ca2918
dca1b36
552bc3c
a46c35e
5bdddd5
3c8a458
c69f6ff
4802229
e7a7a4c
46b95d6
f5ee39e
5cc8eae
7009fa1
910706f
1ebe07b
10cdc07
d035dc4
aa267c0
43dfa46
58b5392
0d5ef70
1c0e406
926d503
68685f1
3811186
7840dfe
7f2cfe5
effd389
8c7adae
4558d29
6629975
409941e
457cbfe
7807fdf
0141d68
f8aa92f
5558e8d
3dc3bf9
99d95f9
53e1d47
518e94f
fb7af8b
ce9b0c0
84be707
899b11e
1ea0d58
3986e35
32dc7a8
48a62d2
ced26e1
528b60a
566460c
5efaa21
77e7fb8
d854c7e
6b75413
330f403
5556ad7
cdae7fe
9b1534d
3b89cef
e532fb1
cd0c9dd
429ebbe
95a89f7
7c9e0eb
8aebca8
6ce95ae
1eaffe1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for not making this text translatable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It definitely should be translated 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of these data attributes are self explanatory, but this "island" part is not, I think this could be improved to be easier to read?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is special and I run into an issue with it as I had to learn it enables Interactivity API runtime for the block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point.
Island is a term that refers to a part of the site that is hydrated and therefore becomes interactive.
The idea of an "islands architecture" was first coined by Etsy's frontend architect Katie Sylor-Miller in 2019, and expanded on in this post by Jason Miller (Preact's creator). Since then, multiple JavaScript frameworks have adopted it: (1, 2, 3...).
Maybe we can change it to
data-wp-interactive
. Would that be easier to read, or do you have any other suggestions?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I think
data-wp-interactive
would be clearer.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Carolina 🙂
I opened this issue to discuss it.
For context, the full version of the Interactivity API is still in that repo, but we'll move everything to the Gutenberg repo after the WP 6.3 feature freeze, including the codebase and discussions.