List View: Adds a renderAdditionalBlockUI prop to ListView #50465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
the
[Feature] List View
|
Size Change: -240 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in dc2af00. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4924939215
|
|
I think this is flexible enough for what we need to achieve here and will help us reduce a lot of duplicated code while giving us the option to iterate on it in the future should we decide on a better solution |
draganescu
approved these changes
May 9, 2023
There was a problem hiding this comment.
I think this is a good start to help us phase out the OffCanvasEditor component and use ListView in its place via private unchangeable props. It's not 100% the best solution but it does advance the goal and can easily be changed later with whatever the better solution will turn out to be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is broken out of #50287. Adds a new
renderAdditionalBlockUIprop to the ListView so that we can inject additional UI for blocks depending on the context we load the ListView in.Why?
This will make it possible to edit blocks using the List View, which is a feature we require when using the ListView in the navigation inspector controls, and in the global navigation sidebar. This approach has already been used in the OffCanvasEditor component.
How?
Adding a new prop and make it private.
Testing Instructions
See #50287