Post Comments From: Prevent hidden input fields from being focusable in Safari. #50834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
Browser Issues
|
Size Change: +26 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 066e477. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5044520845
|
alexstine
approved these changes
May 22, 2023
cbravobernal
changed the title
priethor
added
[Focus] Accessibility (a11y)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50830
What?
It appears hidden input fields with a
display: biockCSS property stay invisible in Safari but become focusable.Why?
As the hidden input fields become focusable, there are invisible tab stops when navigating the page with the Tab key. Invisible tab stops are extremely confusing for keyboard users, including screen reader users.
How?
Make sure to exclude hidden input fields from getting
display: biockin the post comment form block.Testing Instructions
Testing Instructions for Keyboard
See above.
Screenshots or screencast