Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iframe compat layer: clarify how dependencies related to inline styles work #51199

Merged
merged 1 commit into from
Jun 2, 2023
Merged

iframe compat layer: clarify how dependencies related to inline styles work #51199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 30 additions & 13 deletions packages/block-editor/src/components/iframe/use-compatibility-styles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,23 +72,40 @@ export function useCompatibilityStyles() {
if ( matchFromRules( cssRules ) ) {
const isInline = ownerNode.tagName === 'STYLE';

// Add inline styles belonging to the stylesheet.
const inlineCssId = ownerNode.id.replace(
isInline ? '-inline-css' : '-css',
isInline ? '-css' : '-inline-css'
);
const otherElement = document.getElementById( inlineCssId );

// If the matched stylesheet is inline, add the main
// stylesheet before the inline style element.
if ( otherElement && isInline ) {
accumulator.push( otherElement.cloneNode( true ) );
if ( isInline ) {
// If the current target is inline,
// it could be a dependency of an existing stylesheet.
// Look for that dependency and add it BEFORE the current target.
const mainStylesCssId = ownerNode.id.replace(
'-inline-css',
'-css'
);
const mainStylesElement =
document.getElementById( mainStylesCssId );
if ( mainStylesElement ) {
accumulator.push(
mainStylesElement.cloneNode( true )
);
}
}

accumulator.push( ownerNode.cloneNode( true ) );

if ( otherElement && ! isInline ) {
accumulator.push( otherElement.cloneNode( true ) );
if ( ! isInline ) {
// If the current target is not inline,
// we still look for inline styles that could be relevant for the current target.
// If they exist, add them AFTER the current target.
const inlineStylesCssId = ownerNode.id.replace(
'-css',
'-inline-css'
);
const inlineStylesElement =
document.getElementById( inlineStylesCssId );
if ( inlineStylesElement ) {
accumulator.push(
inlineStylesElement.cloneNode( true )
);
}
}
}

Expand Down