Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update React docs link for propTypes #51208

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Update React docs link for propTypes #51208

merged 1 commit into from
Jun 2, 2023

Conversation

benlk
Copy link
Contributor

@benlk benlk commented Jun 2, 2023

What?

The former link now redirects to legacy docs at https://legacy.reactjs.org/docs/typechecking-with-proptypes.html , with a warning link to the current docs at https://react.dev/reference/react/Component#static-proptypes

This updates to the new link

Why?

Prevent linkrot

How?

Updates link

Testing Instructions

  1. Verify that the link goes to the correct location
  2. Verify that the information on the new page is the same as the old page.

Testing Instructions for Keyboard

n/a; this is replacing the href of a link in docs, not changing any user interaction

Copy link
Member

@ndiego ndiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! 🚢

@ndiego ndiego added the [Type] Developer Documentation Documentation for developers label Jun 2, 2023
@ndiego ndiego enabled auto-merge (squash) June 2, 2023 18:15
@ndiego ndiego merged commit 2b38a73 into WordPress:trunk Jun 2, 2023
@github-actions github-actions bot added this to the Gutenberg 16.0 milestone Jun 2, 2023
sethrubenstein pushed a commit to pewresearch/gutenberg that referenced this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants