[ Latest Posts block] Option to always show the [Read more ...] #51213
Conversation
github-actions
bot
added
the
First-time Contributor
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @ghorivipul97! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
There was a problem hiding this comment.
@ghorivipul97 Looks like PHP checks are also failing. Left a couple suggested code changes below.
ghorivipul97
force-pushed
the
update/latest_post_read_more
branch
2 times, most recently
from
7a535f4 to
3db3e4c
Compare
|
@alexstine can you help me to solve "puppeteer" error |
|
@ghorivipul97 Hi. You need to pull the latest changes from the trunk branch and update the pull request, then the tests will run again. Kindly try to solve the PHP errors. |
| .trim() | ||
| .split( ' ', excerptLength ) | ||
| .join( ' ' ) } | ||
| { /* translators: excerpt truncation character, default … */ } |
There was a problem hiding this comment.
The ellipsis is not used anymore so the translators comment should be removed.
|
I also think that read more link should always be on a separate line, what do you think? And maybe there needs to be some spacing added between the list items. Right now, the link is displayed differently in the editor and the front. |
link #22269
What?
Added Read More Link in Latest Post Block
Why?
#22269
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast