Global styles revisions: ensure redirect runs once for back button #51316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to ensure the internal functions are run once, and as intendted
ramonjd
added
[Type] Bug
|
@andrewserong @ndiego Do you think this should be included in the next release? Assuming that #51149 made it in, so we'd need to correct it. I'll add the label just in case. |
ramonjd
added
the
Backport to Gutenberg RC
Yes, it'd be great to include this one. Just taking it for a spin now. |
andrewserong
approved these changes
Jun 8, 2023
There was a problem hiding this comment.
Thanks for the quick fix @ramonjd! This logic looks good to me — we only want this section to fire when editorCanvasContainerView changes, and when that change occurs, we want to reference the location path at the time of that change 👍
All working nicely:
✅ Clicking the revisions link in the browse mode Styles screen correctly opens Revisions
✅ Revisions back button now works as intended
✅ From the Revisions screen, opening the Style Book changes the canvas container and redirects
✅ Opening and closing the Style Book works as before with no unexpected redirects
✅ Style book icon in browse mode Styles screen still works, and clicking the preview with the Style book open persists the container state in edit mode
LGTM! ✨
|
Size Change: -3 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
ramonjd
deleted the
update/revision-button-remove-location-from-dependency-list
branch
fullofcaffeine
pushed a commit
that referenced
this pull request
Jun 9, 2023
…51316) * Removing location?.path from the dependency to avoid infinite loop and to ensure the internal functions are run once, and as intendted * Add disable lint rule
ndiego
removed
the
Backport to Gutenberg RC
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…ordPress#51316) * Removing location?.path from the dependency to avoid infinite loop and to ensure the internal functions are run once, and as intendted * Add disable lint rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I can't click the back button on the global styles revisions panel!
Why?
The
useEffectcallback in GlobalStylesEditorCanvasContainerLink is triggered every timelocation?.pathchanges. So when the path changes andeditorCanvasContainerView === 'global-styles-revisions'is alreadytrueit'll try to executegoTo( '/revisions' )again. Woot!How?
Removing
location?.pathfrom the dependency to avoid infinite loop and to ensure the internal functions are run once, and as intendedTesting Instructions